Skip to content

Update pg-promise to the latest version 🚀 #3954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Jun 25, 2017

Version 6.1.0 of pg-promise just got published.

Dependency pg-promise
Current Version 5.9.7
Type dependency

The version 6.1.0 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of pg-promise.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.


Commits

The new version differs by 2 commits.

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

@vitaly-t
Copy link
Contributor

Looks like there will be some work required on your tests before version 6.x can be used.

The log is flooded with this error:

Connection pool of the database object has been destroyed.

which means that the test framework is calling pgp.end() at some point, to shut down the entire pg-promise library, and then later it continues making calls against the database, which is invalid.

It didn't come up against version 5.x of pg-promise because it was using a single global connection pool, and such granular fault detection wasn't possible.

@flovilmart
Copy link
Contributor

Thanks for the tip! I’ll have a look!

greenkeeper bot added a commit that referenced this pull request Jun 26, 2017
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Jun 26, 2017

Version 6.1.1 just got published.

Update to this version instead 🚀

Commits

The new version differs by 2 commits.

  • 14adfbb docs + upped the version.
  • 44d501c Fixing #356, docs updates.

See the full diff

@vitaly-t
Copy link
Contributor

vitaly-t commented Jun 26, 2017

There is some difference in 6.x for method pgp.end() now.

P.S. I wouldn't worry about upgrading now. The way pg-promise is used here, the upgrade to version 6.x won't offer any benefit.

greenkeeper bot added a commit that referenced this pull request Jun 27, 2017
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Jun 27, 2017

Version 6.1.2 just got published.

Update to this version instead 🚀

Commits

The new version differs by 4 commits.

See the full diff

greenkeeper bot added a commit that referenced this pull request Jun 28, 2017
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Jun 28, 2017

Version 6.2.0 just got published.

Update to this version instead 🚀

Commits

The new version differs by 8 commits.

See the full diff

greenkeeper bot added a commit that referenced this pull request Jun 28, 2017
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Jun 28, 2017

Version 6.2.1 just got published.

Update to this version instead 🚀

Commits

The new version differs by 5 commits.

See the full diff

greenkeeper bot added a commit that referenced this pull request Jun 30, 2017
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Jun 30, 2017

Version 6.2.2 just got published.

Update to this version instead 🚀

Commits

The new version differs by 3 commits.

  • 71425a9 upped the version.
  • c0b44ea adding event handler to direct connections.
  • d145ff0 documentation updates.

See the full diff

greenkeeper bot added a commit that referenced this pull request Jul 1, 2017
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Jul 1, 2017

Version 6.2.3 just got published.

Update to this version instead 🚀

Commits

The new version differs by 5 commits.

  • 665beef upped the version.
  • ea54964 upped the version + dependencies.
  • e5b2ba0 Merge pull request #363 from vitaly-t/error-test
  • 631bc71 reverting custom errors to ES5
  • aba2568 refactoring with eslint rule object-shorthand

See the full diff

greenkeeper bot added a commit that referenced this pull request Jul 1, 2017
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Jul 1, 2017

Version 6.3.0 just got published.

Update to this version instead 🚀

Commits

The new version differs by 9 commits.

  • cf9a55d Merge pull request #364 from vitaly-t/direct-connections
  • 229efb3 docs update.
  • 66e4aca extending lost connection details.
  • 355d7aa refactoring + documentation.
  • cba92a4 extending the event.
  • 4873af1 postpone removing the event listeners.
  • a536ba5 connection error finished, it all works well.
  • cf17714 adding lost to indirect connections.
  • 7d9356f first draft for onConnectionLost

See the full diff

@flovilmart
Copy link
Contributor

@vitaly-t I believe I got a fix, but this warning pops up:

WARNING: Creating a duplicate database object for the same connection.

can it be safely ignored? or should we change something in the createClient function?

@vitaly-t
Copy link
Contributor

vitaly-t commented Jul 2, 2017

@flovilmart if it is in tests, it can be safely ignored. It just means that you keep creating copies of db with the same connection details, which the library considers an anti-pattern.

Alternatively, you can switch off all the warnings in tests, via Initialization option noWarnings.

flovilmart added a commit that referenced this pull request Jul 2, 2017
* fix(package): update pg-promise to version 6.3.0

Closes #3954

* Restores PG adapter after tests that close the connection

* investigation

* Use isolated parse-server to not impeed on other specs

* Update PostgresInitOptions.spec.js
@greenkeeper greenkeeper bot deleted the greenkeeper/pg-promise-6.1.0 branch July 2, 2017 18:31
@flovilmart
Copy link
Contributor

That's all good not! Thanks for the guidance.

@vitaly-t
Copy link
Contributor

vitaly-t commented Jul 2, 2017

That's all good not!

Pardon, you're saying it is no good? 😄

@flovilmart
Copy link
Contributor

Haha, stupid typo! All good now, ran those on an isolated instance in the test suite. Way better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants