-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Update pg-promise to the latest version 🚀 #3954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like there will be some work required on your tests before version 6.x can be used. The log is flooded with this error:
which means that the test framework is calling It didn't come up against version 5.x of |
Thanks for the tip! I’ll have a look! |
Version 6.1.1 just got published. |
There is some difference in 6.x for method pgp.end() now. P.S. I wouldn't worry about upgrading now. The way pg-promise is used here, the upgrade to version 6.x won't offer any benefit. |
Version 6.2.0 just got published. |
Version 6.2.1 just got published. |
Version 6.2.2 just got published. |
Version 6.2.3 just got published. |
Version 6.3.0 just got published.Update to this version instead 🚀 CommitsThe new version differs by 9 commits.
See the full diff |
@vitaly-t I believe I got a fix, but this warning pops up:
can it be safely ignored? or should we change something in the createClient function? |
@flovilmart if it is in tests, it can be safely ignored. It just means that you keep creating copies of Alternatively, you can switch off all the warnings in tests, via Initialization option noWarnings. |
* fix(package): update pg-promise to version 6.3.0 Closes #3954 * Restores PG adapter after tests that close the connection * investigation * Use isolated parse-server to not impeed on other specs * Update PostgresInitOptions.spec.js
That's all good not! Thanks for the guidance. |
Pardon, you're saying it is no good? 😄 |
Haha, stupid typo! All good now, ran those on an isolated instance in the test suite. Way better |
Version 6.1.0 of pg-promise just got published.
The version 6.1.0 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of pg-promise.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Commits
The new version differs by 2 commits.
4b1954d
preparing the release.
1a56018
merging 6.x into master.
See the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴