Skip to content

Scoped packages #4354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 17, 2017
Merged

Scoped packages #4354

merged 5 commits into from
Nov 17, 2017

Conversation

flovilmart
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 16, 2017

Codecov Report

Merging #4354 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4354      +/-   ##
==========================================
- Coverage   92.67%   92.64%   -0.03%     
==========================================
  Files         119      119              
  Lines        8435     8435              
==========================================
- Hits         7817     7815       -2     
- Misses        618      620       +2
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️
src/Controllers/index.js 96.66% <100%> (ø) ⬆️
src/RestWrite.js 93.32% <0%> (-0.19%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.84% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa1e97f...4eea362. Read the comment docs.

Copy link
Contributor

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Should we add a link somewhere that just takes someone to all @parse packages?

@flovilmart
Copy link
Contributor Author

That would be pretty, (https://www.npmjs.com/search?q=scope%3Aparse) what do you think?

@montymxb
Copy link
Contributor

That would be great. Not sure exactly where it would go, but we would never have to update the link when packages are added!

@montymxb
Copy link
Contributor

Actually, maybe it could go here in the README section about Available Adapters.

@flovilmart
Copy link
Contributor Author

@montymxb let me know what you think!

@@ -337,7 +337,10 @@ $ PORT=8080 parse-server --appId APPLICATION_ID --masterKey MASTER_KEY
For the full list of configurable environment variables, run `parse-server --help`.

### Available Adapters
[Parse Server Modules (Adapters)](https://github.com/parse-server-modules)

All official adapters are distributed as scoped pacakges on [npm (@parse)](https://www.npmjs.com/search?q=scope%3Aparse).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Should we keep the github modules as well or are we deprecating that altogether in favor of npm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all official adapters have moved from parse-server-modules to parse-community. Others are still there but not migrated yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re added back a line as there are still some adapter there.

@flovilmart flovilmart merged commit de73f37 into master Nov 17, 2017
@flovilmart flovilmart deleted the scoped-packages branch November 17, 2017 13:33
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* Updates for scoped packages dependencies

* bumps s3 adapter

* Update README.md

* Update README.md

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants