refactoring deleteAllClasses #4464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...to re-use the connection.
flovilmart
previously approved these changes
Dec 27, 2017
| debug(`deleteAllClasses done in ${new Date().getTime() - now}`); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
There seems to be added blank spaces here. Otherwise LGTM
There was a problem hiding this comment.
@flovilmart removed the extra spaces, need re-review 😉
removing extra spaces.
Codecov Report
@@ Coverage Diff @@
## master #4464 +/- ##
==========================================
+ Coverage 92.69% 92.72% +0.02%
==========================================
Files 118 118
Lines 8354 8356 +2
==========================================
+ Hits 7744 7748 +4
+ Misses 610 608 -2
Continue to review full report at Codecov.
|
flovilmart
approved these changes
Dec 27, 2017
flovilmart
pushed a commit
that referenced
this pull request
Dec 29, 2017
* refactoring deleteAllClasses ...to re-use the connection. * Update PostgresStorageAdapter.js removing extra spaces.
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
* refactoring deleteAllClasses ...to re-use the connection. * Update PostgresStorageAdapter.js removing extra spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to re-use the connection.