chore(package): update jasmine to version 3.0.0 #4553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting 3.0, done(something) will fail
flovilmart
force-pushed
the
greenkeeper/jasmine-3.0.0
branch
from
0756bcd to
996fe96
Compare
Codecov Report
@@ Coverage Diff @@
## master #4553 +/- ##
==========================================
+ Coverage 92.87% 93.32% +0.45%
==========================================
Files 118 118
Lines 8491 8931 +440
==========================================
+ Hits 7886 8335 +449
+ Misses 605 596 -9
Continue to review full report at Codecov.
|
With jasmine 3.0, the randomization engine was making the test fails because of the scope of `var`
|
|
|
Yeah, find replace all by const, and fix all wrong conts |
|
@flovilmart Is your email florent _ at _ flovilmart _ dot _ com? |
flovilmart
force-pushed
the
greenkeeper/jasmine-3.0.0
branch
from
484aff3 to
67cbcaa
Compare
|
@dplewis yep it is |
flovilmart
force-pushed
the
greenkeeper/jasmine-3.0.0
branch
from
67cbcaa to
1f741b4
Compare
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
* chore(package): update jasmine to version 3.0.0 Closes parse-community#4547 * Fixes failing tests for jasmine 3.0 Starting 3.0, done(something) will fail * Update tests so they dont leverage var, but let and const With jasmine 3.0, the randomization engine was making the test fails because of the scope of `var` * Remove randomizer * Use same adapter for PG tests, drop table to ensure the tests dont side effect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4547