Skip to content

Adds exposed headers to avoid issue in JS SDK #4934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2018

Conversation

flovilmart
Copy link
Contributor

@flovilmart flovilmart commented Aug 7, 2018

Fixes this issue server side: parse-community/Parse-SDK-JS#622

@flovilmart flovilmart requested review from dplewis and acinader August 7, 2018 14:29
@codecov
Copy link

codecov bot commented Aug 7, 2018

Codecov Report

Merging #4934 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4934      +/-   ##
==========================================
- Coverage   92.92%   92.91%   -0.02%     
==========================================
  Files         119      119              
  Lines        8835     8836       +1     
==========================================
  Hits         8210     8210              
- Misses        625      626       +1
Impacted Files Coverage Δ
src/middlewares.js 98.2% <100%> (+0.01%) ⬆️
src/Routers/PushRouter.js 92.85% <0%> (-3.58%) ⬇️
src/RestWrite.js 93.32% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff25ae2...a76ba9d. Read the comment docs.

@acinader
Copy link
Contributor

acinader commented Aug 7, 2018

read through parse-community/Parse-SDK-JS#622. this looks good to me.

@flovilmart
Copy link
Contributor Author

I'll cherry pick and release pre-3.0.0 versions as well.

@flovilmart flovilmart merged commit a021fef into master Aug 7, 2018
@flovilmart flovilmart deleted the fix/issue-js-sdk-622 branch August 7, 2018 15:13
flovilmart added a commit that referenced this pull request Aug 7, 2018
* Adds exposed headers to avoid issue in JS SDK

* Adds test for headers
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* Adds exposed headers to avoid issue in JS SDK

* Adds test for headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants