Skip to content

Update pg-promise to the latest version 🚀 #6555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Apr 3, 2020
Merged

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Apr 1, 2020


☝️ Important announcement: Greenkeeper will be saying goodbye 👋 and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io


The dependency pg-promise was updated from 10.4.4 to 10.5.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: vitaly.tomilov
License: MIT

Release Notes for 10.5.0
  • Driver has been updated to version 8.0.0; See its changelog.
  • Removed hiding password in connection, as the driver now handles it.
  • Removed idleTimeoutMillis (in TypeScript) from defaults, due to this bug, and #703
  • Updated dependencies + documentation
Commits

The new version differs by 8 commits.

See the full diff


FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@ghost ghost added the Merge On Green label Apr 1, 2020
@ghost ghost merged commit a8a367e into master Apr 3, 2020
@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #6555 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6555      +/-   ##
==========================================
+ Coverage   94.01%   94.02%   +<.01%     
==========================================
  Files         169      169              
  Lines       11850    12200     +350     
==========================================
+ Hits        11141    11471     +330     
- Misses        709      729      +20
Impacted Files Coverage Δ
src/Routers/FilesRouter.js 89.55% <0%> (-3.18%) ⬇️
src/cloud-code/Parse.Cloud.js 97.14% <0%> (-1.04%) ⬇️
src/middlewares.js 97.09% <0%> (-0.12%) ⬇️
src/Adapters/Files/FilesAdapter.js 100% <0%> (ø) ⬆️
src/Controllers/FilesController.js 93.75% <0%> (+0.13%) ⬆️
src/RestWrite.js 93.81% <0%> (+0.16%) ⬆️
src/triggers.js 94.17% <0%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52d35b...34f19ae. Read the comment docs.

@greenkeeper greenkeeper bot deleted the greenkeeper/pg-promise-10.5.0 branch April 3, 2020 14:11
@cbaker6
Copy link
Contributor

cbaker6 commented Apr 3, 2020

@dplewis @acinader I suspect this is going to be a breaking change for Postgres users who use SSL with self-signed certificates mainly because of changes in node-postgres 8 below:

Change default behavior when not specifying rejectUnauthorized with the SSL connection parameters. Previously we defaulted to rejectUnauthorized: false when it was not specifically included. We now default to rejectUnauthorized: true. Manually specify { ssl: { rejectUnauthorized: false } } for old behavior.

This previously gave a warning... I tried to figure out how to pass rejectUnauthorized through the URI string as an object to ssl, but couldn't figure it out. I tried this because pg-promise can use ssl as a boolean (which PostgresConfigParser currently uses) or as a ISSLConfig object.

A possible work-around is to address this in PostgresConfigParser, but my guess is that would result in defining a custom uri structure for this which seems hacky.

If one of you know of a way we can pass the ISSLConfig object through the URI string, then those changes can be applied to PostgresConfigParser. I looked into if skipping the PostgresConfigParser as a whole and just passing the uri string to pg-promise, but URI parsing is currently limited to the ability of pg-connection-string. Pg-promise also mentions you can use connection-string which might be a good way to go as it seems it can covert the entire uri string to an object that can be passed to pg-promise.

Thoughts?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant