Skip to content

Become on non existing user #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
34 changes: 34 additions & 0 deletions spec/ParseUser.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,40 @@ describe('Parse.User testing', () => {
});
});

it("become on non existing user", (done) => {
var user = null;
var sessionToken = null;
var userPointer = null;

Parse.Promise.as().then(function() {
return Parse.User.signUp("9090", "-----");

}).then(function(newUser) {
equal(Parse.User.current(), newUser);

user = newUser;
userPointer = user.toPointer();
sessionToken = newUser.getSessionToken();
ok(sessionToken);

var u = Parse.Object.fromJSON(userPointer);
return u.destroy({useMasterKey:true});

}).then(function() {
return Parse.User.become(sessionToken);
}).then((user) => {
ok(false, "Shouldn't have been able to log in with non existing user.");
}, function(error) {
ok(error);
return Parse.Promise.as();
}).then(function() {
done();
}, function(error) {
ok(false, error);
done();
});
});

it("become", (done) => {
var user = null;
var sessionToken = null;
Expand Down
3 changes: 2 additions & 1 deletion src/Routers/UsersRouter.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,10 @@ export class UsersRouter extends ClassesRouter {
{ _session_token: sessionToken },
{ include: 'user' })
.then((response) => {

if (!response.results ||
response.results.length == 0 ||
!response.results[0].user) {
!response.results[0].user || ( response.results[0].user.__type && response.results[0].user.__type === 'Pointer' ) ) {
throw new Parse.Error(Parse.Error.INVALID_SESSION_TOKEN, 'invalid session token');
} else {
let user = response.results[0].user;
Expand Down