Properly handle serverURL and publicServerUrl in Batch requests #6980 #7049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZachGoldberg
force-pushed
the
zg/fix-6980
branch
from
884d5a4 to
70e0105
Compare
Codecov Report
@@ Coverage Diff @@
## master #7049 +/- ##
==========================================
- Coverage 93.86% 93.84% -0.03%
==========================================
Files 169 169
Lines 12437 12440 +3
==========================================
Hits 11674 11674
- Misses 763 766 +3
Continue to review full report at Codecov.
|
dplewis
suggested changes
Dec 9, 2020
| const startsWithPublic = requestPath.startsWith(publicPath); | ||
| const pathLengthToUse = | ||
| startsWithLocal && startsWithPublic | ||
| ? Math.max(localPath.length, publicPath.length) |
There was a problem hiding this comment.
It took me a second to figure out what this was doing. Good way to tell which one "startsWith" more.
There was a problem hiding this comment.
Sorry about this... I wrote this four times trying to find a clear way to do it and am still unhappy with the readability... definitely open to suggestions on strategy or clarity here!
src/batch.js
Outdated
| ? Math.max(localPath.length, publicPath.length) | ||
| : startsWithLocal | ||
| ? localPath.length | ||
| : publicPath.length; | ||
| // Build the new path by removing the public path | ||
| // and joining with the local path |
There was a problem hiding this comment.
Can you remove this old comment?
dplewis
approved these changes
Dec 9, 2020
dplewis
changed the title
oobidin
pushed a commit
to oobidin/parse-server
that referenced
this pull request
Oct 4, 2022
…-community#6980 (parse-community#7049) * fix: detect if the caller is accessing us via local or parse for batch requests (parse-community#6980) * chore: minor cleanup from PR
oobidin
pushed a commit
to oobidin/parse-server
that referenced
this pull request
Nov 29, 2022
…-community#6980 (parse-community#7049) * fix: detect if the caller is accessing us via local or parse for batch requests (parse-community#6980) * chore: minor cleanup from PR
oobidin
pushed a commit
to revolut-engineering/parse-server
that referenced
this pull request
Nov 29, 2022
…-community#6980 (parse-community#7049) * fix: detect if the caller is accessing us via local or parse for batch requests (parse-community#6980) * chore: minor cleanup from PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6980 for more context
I'm not 100% confident I understand the intended distinction between
serverUrlandpublicServerUrlbut my instinct is that on a production machine I should be able to access parse server via either URL. That seems to be the case for everything BUT batch requests which have an assumption that requests come only from the pubic URL. This patch has a rough-shod attempt at a quick-and-dirty detection of which kind of URL is being used to construct thenewPathappropriately.The included test fails before the patch, passes afterwards.