Skip to content

_Role object must specified name and ACL #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 2, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 24 additions & 7 deletions spec/ParseRole.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,17 +59,16 @@ describe('Parse Role testing', () => {
});

});

it("should recursively load roles", (done) => {

var rolesNames = ["FooRole", "BarRole", "BazRole"];

var createRole = function(name, parent, user) {
var role = new Parse.Object("_Role")
role.set("name", name);
var role = new Parse.Role(name, new Parse.ACL());
if (user) {
var users = role.relation('users');
users.add(user);
users.add(user);
}
if (parent) {
role.relation('roles').add(parent);
Expand All @@ -78,7 +77,7 @@ describe('Parse Role testing', () => {
}
var roleIds = {};
createTestUser().then( (user) => {

return createRole(rolesNames[0], null, null).then( (aRole) => {
roleIds[aRole.get("name")] = aRole.id;
return createRole(rolesNames[1], aRole, null);
Expand All @@ -102,5 +101,23 @@ describe('Parse Role testing', () => {
});
});

it("_Role object should not save without name.", (done) => {
var role = new Parse.Role();
role.save(null,{useMasterKey:true})
.then((r) => {
fail("_Role object should not save without name.");
}, (error) => {
expect(error.code).toEqual(111);
role.set('name','testRole');
role.save(null,{useMasterKey:true})
.then((r2)=>{
fail("_Role object should not save without ACL.");
}, (error2) =>{
expect(error2.code).toEqual(111);
done();
});
});
});

});

3 changes: 2 additions & 1 deletion src/Schema.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ var defaultColumns = {


var requiredColumns = {
_Product: ["productIdentifier", "icon", "order", "title", "subtitle"]
_Product: ["productIdentifier", "icon", "order", "title", "subtitle"],
_Role: ["name", "ACL"]
}

// Valid classes must:
Expand Down