-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
ci: enable more tests on Postgres adapter #7641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I will reformat the title to use the proper commit message syntax. |
Thanks for opening this pull request!
|
Codecov Report
@@ Coverage Diff @@
## master #7641 +/- ##
=======================================
Coverage 93.98% 93.98%
=======================================
Files 181 181
Lines 13354 13354
=======================================
Hits 12551 12551
Misses 803 803
Continue to review full report at Codecov.
|
…into enableTests
Finished updates, this is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The Postgres adapter is catching up!
🎉 This change has been released in version 5.0.0-alpha.2 |
🎉 This change has been released in version 5.0.0-beta.1 |
🎉 This change has been released in version 5.0.0 |
New Pull Request Checklist
Issue Description
A number of test cases are not enabled for the PostgresAdapter though the adapter is able to pass the tests. This can be for a number of reasons such as:
Most of the other tests that can't pass are either
legacy
tests from the original Parse Server, from legacy versions of the servers, or tests that use specific mongo functionality.In addition, some tests are incorrectly labeled to be excluded from postgres, while they specifically should say they should only run on mongo.
Close #7640
Related issue: #7640
Approach
Enable 17+ tests that are able to pass. Modify certain tests designed for mongo to run on both adapters.
With the changes, Postgres runs 2672 of the tests compared to Mongo running 2808 tests, meaning Postgres runs >95% of the tests Mongo runs in the test suite. Another way to look at this is the total amount of tests is 2876. Postgres passes 93% of the test suite while Mongo passes 98%.
TODOs before merging
parse-server/spec/ParsePolygon.spec.js
Line 213 in 80bf578
parse-server/spec/ParsePolygon.spec.js
Line 428 in 80bf578