Skip to content

ci: test server with PostGIS 3.2 #7752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 2, 2022
Merged

ci: test server with PostGIS 3.2 #7752

merged 5 commits into from
Jan 2, 2022

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Dec 30, 2021 •
edited
Loading

New Pull Request Checklist

Issue Description

CI currently not testing against PostGis 3.2. Close #7753

Related issue: #7753

Approach

Add PostGis 3.2 to the CI

TODOs before merging

  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Dec 30, 2021 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Dec 30, 2021 •
edited
Loading

Codecov Report

Merging #7752 (c69221a) into alpha (16b1b2a) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            alpha    #7752      +/-   ##
==========================================
+ Coverage   93.95%   93.98%   +0.02%     
==========================================
  Files         183      183              
  Lines       13640    13640              
==========================================
+ Hits        12816    12819       +3     
+ Misses        824      821       -3
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 95.65% <0.00%> (+0.15%) ⬆️
src/RestWrite.js 94.20% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acfdc54...c69221a. Read the comment docs.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Dec 30, 2021 •
edited
Loading

This is ready for review. This will need repo setting changes to account for name changes to tests (3.1->3.2)...

@cbaker6 cbaker6 changed the title ci: test server with PostGis 3.2 ci: test server with PostGIS 3.2 Dec 30, 2021
@mtrezza
Copy link
Member

mtrezza commented Jan 1, 2022

Will needs settings changes to account for updated tests...

What does that mean?

@cbaker6
Copy link
Contributor Author

cbaker6 commented Jan 1, 2022 •
edited
Loading

Here I was eluding to the "expected/required" tests to pass the CI. Since the 3.2 was added, someone on the PMC has to update the repo settings.

mtrezza
mtrezza reviewed Jan 1, 2022
View reviewed changes
mtrezza
mtrezza approved these changes Jan 2, 2022
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good! Is this ready for merge once the CI passes?

@cbaker6
Copy link
Contributor Author

cbaker6 commented Jan 2, 2022

Yup, it's ready

@mtrezza mtrezza merged commit b106ffc into parse-community:alpha Jan 2, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-alpha.15

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jan 2, 2022
@cbaker6 cbaker6 deleted the postgis3.2 branch January 2, 2022 18:28
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.10

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Mar 15, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PostGIS 3.2 to the CI
3 participants
@cbaker6 @mtrezza @parseplatformorg