ci: Add CI check for Parse Server options definitions #7955

dblythy · 2022-04-28T05:17:22Z

New Pull Request Checklist

I am not disclosing a vulnerability.
I am creating this PR in reference to an issue.

Issue Description

Often, the definitions files are manually edited.

Closes: #7918

Approach

Generates definitions and compares to committed definitions

TODOs before merging

A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

parse-github-assistant · 2022-04-28T05:17:37Z

Thanks for opening this pull request!

🎉 We are excited about your hands-on contribution!

codecov · 2022-04-28T05:24:03Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.25%. Comparing base (af95fe7) to head (d4e3ae6).
Report is 929 commits behind head on alpha.

Additional details and impacted files

@@            Coverage Diff             @@
##            alpha    #7955      +/-   ##
==========================================
+ Coverage   93.82%   94.25%   +0.42%     
==========================================
  Files         182      180       -2     
  Lines       13629    13987     +358     
==========================================
+ Hits        12787    13183     +396     
+ Misses        842      804      -38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dblythy · 2022-04-28T13:38:02Z

Not quite sure why this runs fine locally but github actions responds with [Error: ENOENT: no such file or directory, open './src/options/Definitions.js'] {

mtrezza · 2022-04-28T15:09:48Z

Likely because in the GH container environment the path root is different from your local env.

dblythy · 2022-04-28T15:25:36Z

Ok, thanks for the pointers CI expert! If you could have a quick look at the approach and let me know your general thoughts some time that would be great.

package.json

resources/checkDefinitions.js

mtrezza · 2022-04-28T15:47:15Z

resources/checkDefinitions.js

+  } else {
+    process.exit(0);
+  }
+})();


Could you use const core = require('@actions/core'); and in addition to logging a console.log use core.error. See the existing checks in /ci directory. IIRC I've kept the console.log logging only for debug purposes because core logs are not displayed locally. That core lib is quite convenient, you can define for example what is displayed as the main error for the failing CI job in the CI summary.

src/Options/Definitions.js

* return correct response when revert is used in beforeSave ([parse-community#7839](parse-community#7839)) ([f63fb2b](parse-community@f63fb2b))

…se-server into definitions-ci-check

package.json

parse-github-assistant · 2022-12-16T00:59:53Z

I will reformat the title to use the proper commit message syntax.

mtrezza

That's a very cool one! Will save us a quite some trouble in the future.

parseplatformorg · 2022-12-20T15:59:40Z

🎉 This change has been released in version 6.0.0-alpha.15

parseplatformorg · 2023-01-31T03:21:55Z

🎉 This change has been released in version 6.0.0-beta.1

parseplatformorg · 2023-01-31T03:40:13Z

🎉 This change has been released in version 6.0.0

…y#7955)

dblythy closed this Apr 28, 2022

dblythy reopened this Apr 28, 2022

mtrezza requested changes Apr 28, 2022

View reviewed changes

mtrezza force-pushed the alpha branch 2 times, most recently from 59215e6 to e6d7d8f Compare May 1, 2022 02:29

semantic-release-bot and others added 7 commits May 5, 2022 17:39

chore(release): 5.2.1-alpha.1 [skip ci]

847f156

* return correct response when revert is used in beforeSave ([parse-community#7839](parse-community#7839)) ([f63fb2b](parse-community@f63fb2b))

feat: add definitions CI check

8987627

type

84dd8a3

Update checkDefinitions.js

dc882f4

Update ci.yml

d413d6d

Update checkDefinitions.js

7a7b8d9

Update checkDefinitions.js

6b09c20

dblythy force-pushed the definitions-ci-check branch from 077ee40 to 6b09c20 Compare May 5, 2022 07:39

dblythy added 7 commits May 5, 2022 17:41

Update checkDefinitions.js

6da828a

Merge branch 'definitions-ci-check' of https://github.com/dblythy/par…

131f350

…se-server into definitions-ci-check

Merge branch 'definitions-ci-check' of https://github.com/dblythy/par…

23d5cf4

…se-server into definitions-ci-check

Merge branch 'definitions-ci-check' of https://github.com/dblythy/par…

825c5fa

…se-server into definitions-ci-check

update

616e3a4

check src

d86ec46

fix

9496e2d

Moumouls reviewed Jun 8, 2022

View reviewed changes

package.json Show resolved Hide resolved

dblythy marked this pull request as draft June 8, 2022 12:20

mtrezza and others added 2 commits June 10, 2022 14:46

Merge branch 'alpha' into definitions-ci-check

23d3b6a

Merge branch 'alpha' into definitions-ci-check

98cfa34

parse-github-assistant bot changed the title ~~feat: add definitions CI check~~ feat: Add definitions CI check Dec 16, 2022

dblythy added 11 commits December 16, 2022 12:03

Update ci.yml

1412ac8

Update definitionsCheck.js

5efe65e

Update definitionsCheck.js

c79ce0d

Update definitionsCheck.js

bac45d4

Update definitionsCheck.js

2c98de8

add ci check

a853807

Update package.json

cc48359

add abort

fb877c8

Update Definitions.js

fd1e1e5

Update definitionsCheck.js

2902fe0

Merge branch 'alpha' into definitions-ci-check

d4e3ae6

dblythy marked this pull request as ready for review December 16, 2022 03:11

dblythy requested a review from a team December 16, 2022 03:12

mtrezza approved these changes Dec 17, 2022

View reviewed changes

mtrezza changed the title ~~feat: Add definitions CI check~~ ci: Add CI check for Parse Server options definitions Dec 17, 2022

mtrezza merged commit 5a26426 into parse-community:alpha Dec 17, 2022

parseplatformorg added the state:released-alpha Released as alpha version label Dec 20, 2022

parseplatformorg added the state:released-beta Released as beta version label Jan 31, 2023

parseplatformorg added the state:released Released as stable version label Jan 31, 2023

dblythy added a commit to dblythy/parse-server that referenced this pull request Feb 15, 2023

ci: Add CI check for Parse Server options definitions (parse-communit…

0e27a7c

…y#7955)

mtrezza mentioned this pull request Jan 16, 2025

Add definitions check to CI #7918

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

ci: Add CI check for Parse Server options definitions #7955

ci: Add CI check for Parse Server options definitions #7955

Uh oh!

dblythy commented Apr 28, 2022 •

edited by mtrezza

Loading

Uh oh!

parse-github-assistant bot commented Apr 28, 2022 •

edited

Loading

Uh oh!

codecov bot commented Apr 28, 2022 •

edited

Loading

Uh oh!

dblythy commented Apr 28, 2022

Uh oh!

mtrezza commented Apr 28, 2022

Uh oh!

dblythy commented Apr 28, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mtrezza Apr 28, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

parse-github-assistant bot commented Dec 16, 2022

Uh oh!

mtrezza left a comment •

edited

Loading

Uh oh!

parseplatformorg commented Dec 20, 2022

Uh oh!

parseplatformorg commented Jan 31, 2023

Uh oh!

parseplatformorg commented Jan 31, 2023

Uh oh!

Uh oh!

Uh oh!

ci: Add CI check for Parse Server options definitions #7955

ci: Add CI check for Parse Server options definitions #7955

Uh oh!

Conversation

dblythy commented Apr 28, 2022 • edited by mtrezza Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Pull Request Checklist

Issue Description

Approach

TODOs before merging

Uh oh!

parse-github-assistant bot commented Apr 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thanks for opening this pull request!

Uh oh!

codecov bot commented Apr 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dblythy commented Apr 28, 2022

Uh oh!

mtrezza commented Apr 28, 2022

Uh oh!

dblythy commented Apr 28, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mtrezza Apr 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

parse-github-assistant bot commented Dec 16, 2022

Uh oh!

mtrezza left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parseplatformorg commented Dec 20, 2022

Uh oh!

parseplatformorg commented Jan 31, 2023

Uh oh!

parseplatformorg commented Jan 31, 2023

Uh oh!

Uh oh!

dblythy commented Apr 28, 2022 •

edited by mtrezza

Loading

parse-github-assistant bot commented Apr 28, 2022 •

edited

Loading

codecov bot commented Apr 28, 2022 •

edited

Loading

mtrezza Apr 28, 2022 •

edited

Loading

mtrezza left a comment •

edited

Loading