ci: Fix flaky LiveQuery tests

[dplewis]

Pull Request

• Report security issues confidentially.
• Any contribution is under this license.
• Link this pull request to an issue.

Issue

This live query server isn't shut down properly. If this issue continues then it must be the subscriptions not closing.

https://github.com/parse-community/parse-server/actions/runs/14230874758/job/39881107431?pr=9693

Summary by CodeRabbit

• Tests
  • Improved tests for liveQuery server shutdown by adding checks to verify active connections before and after shutdown.
  • Replaced manual delay logic with a standardized sleep utility for better test consistency.

[parse-github-assistant]

🚀 Thanks for opening this pull request!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (c7871e2) to head (70c414c).
Report is 27 commits behind head on alpha.

Additional details and impacted files

@@            Coverage Diff             @@
##            alpha    #9694      +/-   ##
==========================================
+ Coverage   93.15%   93.17%   +0.01%     
==========================================
  Files         187      187              
  Lines       15066    15066              
==========================================
+ Hits        14035    14037       +2     
+ Misses       1031     1029       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[parseplatformorg]

🎉 This change has been released in version 8.1.1-alpha.1

[parseplatformorg]

🎉 This change has been released in version 8.2.0

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The changes enhance the live query server shutdown tests by adding assertions to verify the number of active connections before and after the shutdown process. The tests now explicitly check that connections exist after subscribing and that all are closed following shutdown. Additionally, the implementation replaces direct use of new Promise and setTimeout with a sleep utility function to manage delays in the tests.

Changes

File(s)	Change Summary
spec/ParseLiveQuery.spec.js	Enhanced shutdown tests to check connection counts before and after shutdown; replaced delay logic with sleep utility.

Sequence Diagram(s)

sequenceDiagram
  participant Test
  participant LiveQueryServer

  Test->>LiveQueryServer: Subscribe to live query
  LiveQueryServer-->>Test: Confirm subscription
  Test->>LiveQueryServer: Get connection count (should be > 0)
  LiveQueryServer-->>Test: Return active connection count
  Test->>LiveQueryServer: Initiate shutdown
  LiveQueryServer-->>Test: Shutdown initiated
  Test->>LiveQueryServer: Wait (sleep)
  Test->>LiveQueryServer: Get connection count (should be 0)
  LiveQueryServer-->>Test: Return connection count (0)

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c7871e2 and 70c414c.

📒 Files selected for processing (1)

• spec/ParseLiveQuery.spec.js (2 hunks)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.