Skip to content

Commit 18d0e0e

Browse files
authored
Configure Simplecov correctly (rspec#2457)
* Configure simplecov correctly Simplecov 0.15.x allows regexps for filtering paths that seems to break out naively configured relative paths, unsure if we were correct beforehand but this change fixes the build. * Removing pending for JRuby 9000, issue fixed upstream * Update spec suffix for latest JRuby
1 parent b90fd3c commit 18d0e0e

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

script/rspec_with_simplecov

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@ begin
2828
require 'simplecov'
2929

3030
SimpleCov.start do
31-
add_filter "./bundle/"
32-
add_filter "./tmp/"
33-
add_filter "./spec/"
31+
add_filter "bundle/"
32+
add_filter "tmp/"
33+
add_filter "spec/"
3434
minimum_coverage(100)
3535
end
3636
end

spec/integration/spec_file_load_errors_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
let(:failure_exit_code) { rand(97) + 2 } # 2..99
99

1010
if RSpec::Support::Ruby.jruby_9000?
11-
let(:spec_line_suffix) { ":in `<top>'" }
11+
let(:spec_line_suffix) { ":in `<main>'" }
1212
elsif RSpec::Support::Ruby.jruby?
1313
let(:spec_line_suffix) { ":in `(root)'" }
1414
elsif RUBY_VERSION == "1.8.7"

spec/rspec/core/reporter_spec.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -284,10 +284,6 @@ module RSpec::Core
284284

285285
describe "#notify_non_example_exception" do
286286
it "sends a `message` notification that contains the formatted exception details" do
287-
if RSpec::Support::Ruby.jruby_9000?
288-
pending "RSpec gets `Unable to find matching line from backtrace` on JRuby 9000"
289-
end
290-
291287
formatter_out = StringIO.new
292288
formatter = Formatters::ProgressFormatter.new(formatter_out)
293289
reporter.register_listener formatter, :message

0 commit comments

Comments
 (0)