This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Configure Simplecov correctly #2457
Merged
+4
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplecov 0.15.x allows regexps for filtering paths that seems to break out naively configured relative paths, unsure if we were correct beforehand but this change fixes the build.
|
This is green and fixes the rspec-core build, can I get a review from someone? /cc @rspec/rspec |
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
* Configure simplecov correctly Simplecov 0.15.x allows regexps for filtering paths that seems to break out naively configured relative paths, unsure if we were correct beforehand but this change fixes the build. * Removing pending for JRuby 9000, issue fixed upstream * Update spec suffix for latest JRuby
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplecov 0.15.x allows regexps for filtering paths that seems to break our naively configured relative paths, unsure if we were correct beforehand but this change fixes the build.