Make unittest.mock.Mock not appear callable
#352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernc
reviewed
Aug 9, 2021
There was a problem hiding this comment.
Can you add a minimal unit test showing that documenting Mock objects doesn't crash and so that we don't accidentally break this Python bug workaround in the future? I'd also test assert inspect.signature(Mock(spec=lambda x: x)) in order to catch it when Python finally fixes the thing.
Terrance
force-pushed
the
mock-workaround
branch
from
27c8060 to
b014542
Compare
|
I've included a class with mocks in the test class' example module, and added a test against the signature as an expected failure (so it will show up as an unexpected success if Python's behaviour changes in the future). |
|
Lgtm. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #350.