Configuration of connection settings as URL #271
Conversation
|
This is a duplicate of https://github.com/videlalvaro/RabbitMqBundle/issues/113 If you have time and will of submitting a PR, I would welcome it. |
|
Hi @videlalvaro I've converted this one into a PR (I don't think I can do this with #113, can I?). Feedback appreciated. Especially one cannot set the |
| another: | ||
| # A different (unused) connection defined by an URL. One can omit all parts, | ||
| # except the scheme (amqp:). If both segment in the URL and a key value (see above) | ||
| # are given the value from the URL takes precedence. |
There was a problem hiding this comment.
why does the URL overrides what ones set above in a connection specifically? I would do it the other way around, the URL fills in values that might have not been specified in the connections confs
|
Are you following this spec: https://www.rabbitmq.com/uri-spec.html ? |
|
Yes, at least I tried. Tell me, when I missed something. On the other hand the spec cover pretty common URIs, so there should be no bigger surprise. |
|
Any replies to my comment:
|
|
@kingcrunch did you see my comments above? I would really like to merge your PR |
|
@videlalvaro Sorry, I indeed missed that comment. The reason the URL overwrites the other settings is, that this is the way the |
|
@kingcrunch OK, if that's the way I'll review this again then. |
|
👍 it would be great to have this merged |
|
Is there a reason this is not merged ? |
Something like amqp://foo:bar@localhost/baz The intention is to allow to specify exactly one configuration option per connection, which is easier to outsource into parameter files.
|
At least there were some conflicts now. I've rebased the branch, so somebody can review again and merge afterwards. |
It would be nice, if I could configure the connection settings as a single string for example as an URL instead of 4 separate keys.