Skip to content

Logger was not working properly #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2016
Merged

Logger was not working properly #375

merged 1 commit into from
Jul 31, 2016

Conversation

alexbumbacea
Copy link
Contributor

Logger was not working properly.

@skafandri
Copy link
Collaborator

What about adding the check here
So it will be checked only once

@alexbumbacea
Copy link
Contributor Author

alexbumbacea commented Jul 25, 2016

The problem is that inside the "Extension" class the service "@logger" is not yet available. Checking it there would be the same issue. The proposed fix, will simply not call the setter if the "@logger" is not available.

@alexbumbacea
Copy link
Contributor Author

@skafandri can we merge this?

Checking for the logger at that point can not be done as the definition of logger is not yet loaded into the container. The proposed solution is the optimal i have found.

@skafandri skafandri merged commit 01258ee into php-amqplib:master Jul 31, 2016
@alexbumbacea alexbumbacea deleted the fixmissinglogger branch August 1, 2016 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants