Skip to content

Ensure multiple consumer follows same processing logic as normal consumer #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2016

Conversation

McSimp
Copy link
Contributor

@McSimp McSimp commented Sep 27, 2016

Currently MultipleConsumer does not handle exceptions in the same way as the regular Consumer since it uses its own processQueueMessage instead of processMessage, which does not include handlers for exceptions like StopConsumerException.

I think that the MultipleConsumer should probably have the same behaviour for these exceptions, so I've placed the relevant code in processMessageQueueCallback (I'm open to a better name for this) which is called by processMessage in Consumer and processQueueMessage in MultipleConsumer. This way when new functionality is added, both consumers should continue to have the same behaviour.

@stloyd stloyd added the Bug fix label Sep 27, 2016
@skafandri skafandri merged commit a7f2745 into php-amqplib:master Oct 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants