Skip to content

Align interface with the implementation of the Message Producer #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2021
Merged

Align interface with the implementation of the Message Producer #424

merged 1 commit into from
Mar 16, 2021

Conversation

mbiagetti
Copy link
Contributor

close #423

@skafandri skafandri added this to the 2.x.x milestone Jan 27, 2017
@sebidchi
Copy link

sebidchi commented Jul 6, 2017

Any news?

@akondas
Copy link

akondas commented May 25, 2018

@skafandri is something blocking this MR?

@mbiagetti
Copy link
Contributor Author

can i do something in order to merge this?

@markitosgv
Copy link

Could you please fix this? How can I put custom headers to my messages?

@mbiagetti
Copy link
Contributor Author

@danieljonderko @dawidrylko @marmichalski any ETA about merging this PR?

@dawidrylko
Copy link

idk @mbiagetti, still waiting 😞

@markitosgv
Copy link

markitosgv commented Jun 15, 2018 •
edited
Loading

any update? I want to use exchange x-delay custom header

@cawolf
Copy link

cawolf commented Jan 15, 2020

Hi all, can you tell me, what is blocking this PR from being merged? Can we help dealing with these issues?

@mbiagetti
Copy link
Contributor Author

Thanks @marmichalski for the approval!
Are you take care of merging it?

@marmichalski
Copy link

@mbiagetti unfortunately not. I am also waiting for this to be merged.

@mihaileu mihaileu merged commit 187d448 into php-amqplib:master Mar 16, 2021
@mihaileu
Copy link
Collaborator

Thanks for you PR

@mbiagetti
Copy link
Contributor Author

@mihaileu You're welcome!

mihaileu added a commit to mihaileu/RabbitMqBundle that referenced this pull request Mar 16, 2021
@mihaileu
Revert "Merge pull request php-amqplib#424 from mbiagetti/master"
95caa3f 
This reverts commit 187d448, reversing
changes made to aaefc33.
@mihaileu
Copy link
Collaborator

@mbiagetti I'll do a rollback and a new tag as this is a breaking change an it would require a new major release.
Maybe in the next major release we will include this.

#625

mihaileu added a commit that referenced this pull request Mar 16, 2021
@mihaileu
Merge pull request #625 from mihaileu/rollback_breaking_changes
c901852 
Revert "Merge pull request #424 from mbiagetti/master"
@mihaileu
Copy link
Collaborator

We will include this fix in the next major version 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljonderko danieljonderko danieljonderko approved these changes

@dawidrylko dawidrylko dawidrylko approved these changes

@marmichalski marmichalski marmichalski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.x.x
Development

Successfully merging this pull request may close these issues.

ProducerInterface not aligned with the implementation
10 participants
@mbiagetti @sebidchi @akondas @markitosgv @dawidrylko @cawolf @marmichalski @mihaileu @danieljonderko @skafandri