Skip to content

Graceful max execution options is now available for MC #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 15, 2018
Merged

Graceful max execution options is now available for MC #468

merged 3 commits into from
Jan 15, 2018

Conversation

chernecov
Copy link
Contributor

Graceful max execution options is now available for multiple consumers.

@chernecov chernecov closed this Sep 6, 2017
@chernecov chernecov reopened this Sep 6, 2017
…xecution

Multiple consumer graceful max execution
@chernecov
Copy link
Contributor Author

chernecov commented Sep 7, 2017

Failing tests are not connected with changes:
5.3 is not pre-installed; installing Downloading archive: https://s3.amazonaws.com/travis-php-archives/binaries/ubuntu/14.04/x86_64/php-5.3.tar.bz2 0.16s$ curl -s -o archive.tar.bz2 $archive_url && tar xjf archive.tar.bz2 --directory / bzip2: (stdin) is not a bzip2 file. tar: Child returned status 2 tar: Error is not recoverable: exiting now 0.00s 0.01s$ phpenv global 5.3 rbenv: version 5.3' not installed The command "phpenv global 5.3" failed and exited with 1 during .

@oleg-andreyev
Copy link

Just remove 5.3 from .travis.yml ;)

@acasademont
Copy link

Ah, this is what I was looking for!

@przemyslawlis
Copy link

This is much needed!

@oleg-andreyev
Copy link

@stloyd can you please review this PR?

@stloyd
Copy link
Collaborator

stloyd commented Nov 8, 2017

@oleg-andreyev Please rebase with latest master to make tests passing

@chernecov
Copy link
Contributor Author

@stloyd Please, review.

@stloyd stloyd merged commit f1d5285 into php-amqplib:master Jan 15, 2018
@stloyd
Copy link
Collaborator

stloyd commented Jan 15, 2018

Looks good, thanks @chernecov !

@chernecov
Copy link
Contributor Author

@stloyd Thanks you.
Can I ask you to review #418
I really want these changes to be merged, and may be you would prefer different approach, in this case I would be happy to re-implement it according to your suggestions.
Thanks in advance.

@lushc lushc mentioned this pull request Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants