Require php-amqplib ^2.12.2 #627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version is the only one that disallows installation on PHP 8.0. While 2.12.0 and 2.12.1 are installable on php: >=5.6.3. In SimpleBus we test our dependencies with `lowest` and therefore this fails on PHP 8.0. See PR with failing tests SimpleBus/SimpleBus#115 Of course, we could add a conflict, but I believe this should be done here.
ramunasd
approved these changes
Mar 17, 2021
mihaileu
approved these changes
Mar 17, 2021
|
Thanks for merging. Would be great to have this tagged 🙏 |
|
2.6.0 tag released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version is the only one that disallows installation on PHP 8.0. While 2.12.0 and 2.12.1 are installable on php: >=5.6.3.
In SimpleBus we test our dependencies with
lowestand therefore this fails on PHP 8.0.See PR with failing tests SimpleBus/SimpleBus#115
Of course, we could add a conflict, but I believe this should be done here.