Cluster usage possibility #637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Torondor27
commented
May 14, 2021
Torondor27
commented
- Added possibility to use multiple hosts
- Tests added
- Small refactoring is made
ramunasd
reviewed
May 17, 2021
| } | ||
|
|
||
| // No need to unpack options, they will be handled inside connection classes | ||
| return $this->class::create_connection($hosts, $options); |
There was a problem hiding this comment.
Please bear in mind that there is no smart logic and it does not spread load accross cluster. All requests will come to first defined host unless it's unrecheable(dead).
ramunasd
approved these changes
May 17, 2021
mihaileu
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.