Skip to content

php-amqplib/php-amqplib takes context as a parameter #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2021
Merged

php-amqplib/php-amqplib takes context as a parameter #648

merged 2 commits into from
Jul 6, 2021

Conversation

winus
Copy link
Contributor

@winus winus commented Jul 1, 2021

ssl_context is not used by php-amqplib/php-amqplib. 'context' is.

ssl_context is not used by php-amqplib/php-amqplib. 'context' is.
@winus winus requested a review from mihaileu as a code owner July 1, 2021 11:38
@mihaileu
Copy link
Collaborator

mihaileu commented Jul 5, 2021

@winus thx for your PR, could you please check the failed tests?

@winus
Copy link
Contributor Author

winus commented Jul 5, 2021

@winus thx for your PR, could you please check the failed tests?

Sure, I’ll take a look tomorrow.

@mihaileu mihaileu closed this Jul 6, 2021
@mihaileu mihaileu reopened this Jul 6, 2021
@mihaileu mihaileu merged commit da40764 into php-amqplib:master Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants