refs #664: message handling on StopConsumerException fix #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaileu
reviewed
Oct 22, 2021
RabbitMq/BatchConsumer.php
Outdated
| // Reject and drop | ||
| $this->getMessageChannel($deliveryTag)->basic_reject($deliveryTag, false); | ||
| } else { | ||
| } elseif ($processFlag !== ConsumerInterface::MSG_ACK_SENT) { | ||
| // Remove message from queue only if callback return not false | ||
| $this->getMessageChannel($deliveryTag)->basic_ack($deliveryTag); | ||
| } |
There was a problem hiding this comment.
what happens for "else" case if there are cases ?
There was a problem hiding this comment.
what do you mean by 'cases'?
ConsumerInterface::MSG_ACK_SENT means ACK was already sent, so another ACK should not be sent
There was a problem hiding this comment.
Perhaps there is no logical "else" part, but this code style is quite confusing. I would recommened to have "else" part. Something like this:
} elseif ($processFlag === ConsumerInterface::MSG_ACK_SENT) {
// do nothing, ack already sent
} else {
// Remove message from queue only if callback return not false
$this->getMessageChannel($deliveryTag)->basic_ack($deliveryTag);
}
This does exactly the same and has better readability. WDYT?
There was a problem hiding this comment.
that sounds sane to make it bit more readable
ramunasd
approved these changes
Nov 4, 2021
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed message handling on
StopConsumerExceptioninBatchConsumeras it ignored process flag entirely