Added channel_rpc_timeout as possible option

[bravoman]

Added channel_rpc_timeout as a possible option for configuring the bundle default connection.

[bravoman]

Depends on this pull request: php-amqplib/php-amqplib#1041

[bravoman]

php-amqplib/php-amqplib#1041 is merged already. So now I guess a version bump on the php-amqplib side the composer requirement needs to be upgraded.

[Eloar]

It seems tests should be updated with new parameter.

[bravoman]

mihaileu is this anywhere near a solution? Or do I need some insight in the inner workings of this bundle? I'm quite new here.

Oh and I guess we're still waiting for php-amqplib 3.4.1 here:

[mszczesniak94]

@bravoman 👏

I see there are missing changes in https://github.com/php-amqplib/RabbitMqBundle/blob/master/DependencyInjection/Configuration.php

->scalarNode('channel_rpc_timeout')->defaultValue(0.0)->end()

It would be nice to add information about this parameter to readme eg. this feature requires php-amqplib/php-amqplib: ^3.5.0 change log here and add channel_rpc_timeout to listed parameters.

https://github.com/php-amqplib/RabbitMqBundle/blob/master/README.md

[mihaileu]

@bravoman an update in readme will help to move it forward

[bravoman]

Suggestion comments added

[bravoman]

Anything else needed for this to move forward?

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[github-actions]

This PR was closed because it has been stalled for 10 days with no activity.