Skip to content

Fix access to private static properties #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2017
Merged

Fix access to private static properties #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Discovery/ConfiguredClientsStrategy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,24 +35,24 @@ class ConfiguredClientsStrategy implements DiscoveryStrategy, EventSubscriberInt
*/
public function __construct(HttpClient $httpClient = null, HttpAsyncClient $asyncClient = null)
{
static::$client = $httpClient;
static::$asyncClient = $asyncClient;
self::$client = $httpClient;
self::$asyncClient = $asyncClient;
}

/**
* {@inheritdoc}
*/
public static function getCandidates($type)
{
if ($type === HttpClient::class && static::$client !== null) {
if ($type === HttpClient::class && self::$client !== null) {
return [['class' => function () {
return static::$client;
return self::$client;
}]];
}

if ($type === HttpAsyncClient::class && static::$asyncClient !== null) {
if ($type === HttpAsyncClient::class && self::$asyncClient !== null) {
return [['class' => function () {
return static::$asyncClient;
return self::$asyncClient;
}]];
}

Expand Down