Skip to content

Add discovered clients functional tests #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2017
Merged

Add discovered clients functional tests #182

merged 1 commit into from
Jul 7, 2017

Conversation

fbourigault
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets partially #109
Documentation n/a
License MIT

This just add functional tests on discovered clients as I will refactor this to use xml configuration instead of PHP in HttplugExtension. This will help me to not break discovered clients!

@fbourigault fbourigault requested a review from Nyholm July 7, 2017 09:21
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I like it.

@fbourigault fbourigault merged commit 327df14 into php-http:master Jul 7, 2017
@fbourigault
Copy link
Contributor Author

Thanks for the review!

@fbourigault fbourigault deleted the add-discovered-clients-tests branch July 7, 2017 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants