add discovery functional tests when discovery is forced or disabled #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
reviewed
Jul 7, 2017
| $loader->load(__DIR__.'/config/config_'.$this->getEnvironment().'.yml'); | ||
| if ($this->isDebug()) { | ||
| $loader->load(__DIR__.'/config/config_debug.yml'); | ||
| } |
There was a problem hiding this comment.
else {
//load config/config.yml
}
There was a problem hiding this comment.
config.yml have been renamed to config_test.yml to always have a configuration file matching the current environment.
Nyholm
reviewed
Jul 7, 2017
| $container = $this->getContainer(true, 'discovery_forced'); | ||
|
|
||
| $this->assertFalse($container->has('httplug.auto_discovery.auto_discovered_client')); | ||
| $this->assertFalse($container->has('httplug.auto_discovery.auto_discovered_async')); |
There was a problem hiding this comment.
Should these be false on both testDisabledDiscovery and testForcedDiscovery?
There was a problem hiding this comment.
Yes, when forced, we use the service id provided by the user. IMHO, those services shouldn't be public as we use them as httplug.discovery arguments.
Nyholm
approved these changes
Jul 7, 2017
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add more tests related to discovery and will help to get #183 refactoring safe.