-
Notifications
You must be signed in to change notification settings - Fork 50
Add BaseUriPlugin support. ISSUE-235 #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
c51720a
f7aa143
d44c8d5
601953c
b1257a0
75ab4b3
e22007b
cbde5ea
3b3629c
45380b2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -199,9 +199,18 @@ private function configurePluginByName($name, Definition $definition, array $con | |
/* client specific plugins */ | ||
|
||
case 'add_host': | ||
$uriService = $serviceId.'.host_uri'; | ||
$this->createUri($container, $uriService, $config['host']); | ||
$definition->replaceArgument(0, new Reference($uriService)); | ||
$hostUriService = $serviceId.'.host_uri'; | ||
$this->createUri($container, $hostUriService, $config['host']); | ||
$definition->replaceArgument(0, new Reference($hostUriService)); | ||
$definition->replaceArgument(1, [ | ||
'replace' => $config['replace'], | ||
]); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. missing break There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you still need to add a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @dbu I fixed all review, can you please review my PR? |
||
|
||
break; | ||
case 'base_uri': | ||
$baseUriService = $serviceId.'.base_uri'; | ||
$this->createUri($container, $baseUriService, $config['uri']); | ||
$definition->replaceArgument(0, new Reference($baseUriService)); | ||
$definition->replaceArgument(1, [ | ||
'replace' => $config['replace'], | ||
]); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82,7 +82,7 @@ | |
}, | ||
"extra": { | ||
"branch-alias": { | ||
"dev-master": "1.8-dev" | ||
"dev-master": "1.9-dev" | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd say: "Allow to configure ..."