-
Notifications
You must be signed in to change notification settings - Fork 50
Add mock client factory for test purpose. #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2641a95
Add mock client factory for test purpose.
3144ea8
Style fix
13cbc2e
Create client if it doesn't exist.
140e96a
Remove mock factory definition when library is missing.
dd1cb9a
Add suggest with mock-client lib.
c2f3ac6
Move service definition to a dedicated file.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
<?php | ||
|
||
namespace Http\HttplugBundle\ClientFactory; | ||
|
||
use Http\Mock\Client; | ||
|
||
/** | ||
* @author Gary PEGEOT <[email protected]> | ||
*/ | ||
class MockFactory implements ClientFactory | ||
{ | ||
/** | ||
* @var Client | ||
*/ | ||
private $client; | ||
|
||
/** | ||
* @param Client $client | ||
*/ | ||
public function setClient(Client $client) | ||
{ | ||
$this->client = $client; | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function createClient(array $config = []) | ||
{ | ||
if (!class_exists(Client::class)) { | ||
throw new \LogicException('To use the mock adapter you need to install the "php-http/mock-client" package.'); | ||
} | ||
|
||
if (!$this->client) { | ||
$this->client = new Client(); | ||
} | ||
|
||
return $this->client; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -68,5 +68,6 @@ | |
<service id="httplug.factory.socket" class="Http\HttplugBundle\ClientFactory\SocketFactory" public="false"> | ||
<argument type="service" id="httplug.message_factory"/> | ||
</service> | ||
<service id="httplug.factory.mock" class="Http\HttplugBundle\ClientFactory\MockFactory" public="false" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i think this service should be removed from the container when the mock client is not available. that way, users notice problems at container build time instead of at runtime. |
||
</services> | ||
</container> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
<?php | ||
/** | ||
* This file is part of the HttplugBundle package. | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Http\HttplugBundle\Tests\Unit\ClientFactory; | ||
|
||
use Http\HttplugBundle\ClientFactory\MockFactory; | ||
use Http\Mock\Client; | ||
use PHPUnit\Framework\TestCase; | ||
|
||
/** | ||
* @author Gary PEGEOT <[email protected]> | ||
*/ | ||
class MockFactoryTest extends TestCase | ||
{ | ||
public function testCreateClient() | ||
{ | ||
$factory = new MockFactory(); | ||
$client = $factory->createClient(); | ||
|
||
$this->assertInstanceOf(Client::class, $client); | ||
|
||
$client = new Client(); | ||
|
||
$factory->setClient($client); | ||
|
||
$this->assertEquals($client, $factory->createClient()); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of removing a definition when the class does not exist, could you move the relevant service definition to a dedicated file and load this file if the class is available?