Skip to content

Use twig.strict_variables: '%kernel.debug%' #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jun 28, 2018

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
Documentation
License MIT

What's in this PR?

This will fix the following deprecation notice:

 8x: Relying on the default value ("false") of the "twig.strict_variables" configuration option is deprecated since Symfony 4.1. You should use "%kernel.debug%" explicitly instead, which will be the new default in 5.0.
    2x in DiscoveredClientsTest::testDiscoveredClient from Http\HttplugBundle\Tests\Functional
    2x in DiscoveredClientsTest::testDiscoveredClientWithProfilingEnabled from Http\HttplugBundle\Tests\Functional
    2x in DiscoveredClientsTest::testDisabledDiscovery from Http\HttplugBundle\Tests\Functional
    2x in DiscoveredClientsTest::testForcedDiscovery from Http\HttplugBundle\Tests\Functional

@Nyholm
Copy link
Member Author

Nyholm commented Jun 28, 2018

Thank you for the review. Travis is failing but they are unrelated.

@Nyholm Nyholm merged commit a6466b4 into master Jun 28, 2018
@Nyholm Nyholm deleted the patch-twig-strict branch June 28, 2018 13:43
@dbu
Copy link
Collaborator

dbu commented Jun 29, 2018

thanks!

@Nyholm
Copy link
Member Author

Nyholm commented Jun 29, 2018

Thank you for the reviews and merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants