fix paths for scrutinizer #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sagikazarmark any idea why scrutinizer fails here? even if some of the tests fail scrutinizer should still work i think. |
|
@dbu Travis fails and scrutinizer waits for external code coverage. Feel free to merge this, problem will be solved once tests are back to green. |
|
but the install does not fail on travis now, its only that one of the
tests failed. does that make scrutinizer think it should not look at
coverage?
|
|
Coverage is uploaded by the travis script in the after_success hook. Otherwise coverage is not generated at all. If no coverage is received by scrutinizer in a given time (300 seconds by default I think) then it fails. |
|
ah, makes sense. lets hope puli can be fixed soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.