validate type specific options #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public static function validateAuthenticationType($expected, $actual, $authName) | ||
| { | ||
| unset($actual['type']); | ||
| if ($expected == $actual) { |
There was a problem hiding this comment.
Make a comment that you actually intend to do == instead of ===.
|
Cool. I like it. =) |
| if (empty($config['username']) || empty($config['password'])) { | ||
| throw new InvalidConfigurationException('Authentication "basic" requires both "username" and "password".'); | ||
| } | ||
| Configuration::validateAuthenticationType(['username', 'password'], array_keys($config), 'basic'); |
There was a problem hiding this comment.
Should be self::validateAuthenticationType right?
There was a problem hiding this comment.
Stupid question: since it is a closure, why can't it be $this->validateAuthenticationType?
There was a problem hiding this comment.
i was not sure with closure and scope, to be honest ;-)
will try $this->validate... can that method then even be private?
There was a problem hiding this comment.
Using $this in a closure has been supported since php 5.4. I just tried this: https://3v4l.org/gvIgS
dbu
force-pushed
the
dbu-patch-1
branch
3 times, most recently
from
6ee6e4c to
875dd51
Compare
|
fixed to use $this, and added the missing tests for the new configuration (and plugin configuration in general) |
|
Cool. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Nyholm trying to do this validation thing