Fix debug tool registration #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ### Fixed | ||
|
|
||
| - Do not register debug tools debugging is disabled (eg. in prod mode) |
There was a problem hiding this comment.
...debug tools when debugging is...
|
good job, looks right to me. did you try it out? wonder if we could (not in this PR, but in general) add integration tests for both dev and prod mode to make sure we don't break this again. |
Debug collectors and tools like that should not be configured when debug mode is disabled.
sagikazarmark
force-pushed
the
fix_toolbar
branch
from
eb9cfa2 to
fcdf81f
Compare
|
Yes we should, along with this: #95 |
|
didn't this PR fix that the toolbar is enabled in prod mode? |
|
This is the code that decides whether we have a toolbar or not |
|
The problem was that this configuration was not applied in all cases when some debug service was registered/linked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fixes the bundle in production mode.
Why?
In production mode (and when debug mode is disabled) debug tools should not be registered in the clients, otherwise we get weird service not found errors.