Add PHP requirements & travis fixes #6
Conversation
| @@ -14,7 +14,8 @@ | |||
| } | |||
| }, | |||
| "require": { | |||
| "amphp/artax": "^3", | |||
| "php": "^7.0", | |||
There was a problem hiding this comment.
This should be >=7.0 as PHP doesn't follow semantic versioning anyway.
There was a problem hiding this comment.
But we do not support PHP8.
If one should be super strict we should write: 7.0.* || 7.1.*. Do you think we should do that?
There was a problem hiding this comment.
Right, and we don't support 7.2 either strictly speaking, because it isn't in feature freeze yet. There are some BC breaks in every version of PHP. What's the purpose of restricting the upper bound? Most code will just run fine. As long as PHP itself isn't installed via Composer, I don't see any reason to restrict the upper bound, which will mostly just work fine for new versions.
There was a problem hiding this comment.
That said, PHP 8.0 is probably far enough away, so it's not too much work to bump it once every 5-10 years.
There was a problem hiding this comment.
Yeah. That is why I suggested ^7.0 because 7.0.* || 7.1.* is overkill and >=7.0 is too generous.
There was a problem hiding this comment.
Code that ran fine on 5.6 mostly runs fine on 7.0, but I don't care enough to discuss it further. Let's wait for 8.0.
There was a problem hiding this comment.
True. It is a minor thing.
|
Why doesn't it run any tests? https://travis-ci.org/php-http/artax-adapter/jobs/251959910 |
|
(Found it) |
|
Yes, forgot to update the |
|
Im done with this PR. Merge it if you like it. |
|
LGTM. |
|
Thank you for merging. |
No description provided.