Bugfixes with blacklist #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmponos
reviewed
Dec 26, 2019
gmponos
approved these changes
Dec 26, 2019
There was a problem hiding this comment.
A small typo change only.
Although it is not related with the current PR please consider at some point refactoring the tests and using actual objects.. For instance if you used ArrayAdapter and an actual Request object I believe some of the tests changes there would not be needed now.
Anyway as I said it is not blocking for the current PR.
|
Yeah, But that is not how PHPSpec is working (as far as I know). But I would love to do that. =) Thank you for the review |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #62
The BC breaking change is that we allow any regex delimiter.