Skip to content

Added HttpClientNoMatchException for HttpClientRouter #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 4, 2019
Merged

Added HttpClientNoMatchException for HttpClientRouter #153

merged 4 commits into from
Jan 4, 2019

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jan 4, 2019

Q A
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
Related tickets fixes #44
Documentation
License MIT

@Nyholm Nyholm added this to the v2.0.0 milestone Jan 4, 2019
@Nyholm Nyholm requested a review from joelwurtz January 4, 2019 08:04
dbu
dbu reviewed Jan 4, 2019
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think strictly speaking this is a BC break. which is fine as we move to 2.0, but we should add an entry to the changelog about no longer throwing a RequestException but the HttpClientNoMatchException which is a general TransferException.

src/Exception/HttpClientNoMatchException.php Outdated
*
* @author Tobias Nyholm <[email protected]>
*/
class HttpClientNoMatchException extends TransferException
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be final?

@dbu
Copy link
Contributor

dbu commented Jan 4, 2019

there are tests asserting the RequestException that need to be adjusted.

@Nyholm
Copy link
Member Author

Nyholm commented Jan 4, 2019

Oh, thank you for fixing this PR for me.

@dbu dbu merged commit de6dfdf into master Jan 4, 2019
@dbu dbu deleted the issue-44 branch January 4, 2019 09:30
@dbu
Copy link
Contributor

dbu commented Jan 4, 2019

felt it was easier than telling you what to do :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

@joelwurtz joelwurtz Awaiting requested review from joelwurtz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Use HttpClientNotFoundException for HttpClientRouter
2 participants
@Nyholm @dbu