Skip to content

Test against symfony versions #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Nov 30, 2017
Merged

Test against symfony versions #90

Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
bae14a7
Test agains symfony versions
Nyholm Nov 18, 2017
1cb572b
cs fixes
Nyholm Nov 18, 2017
f1cb956
Improve travis tests
Nyholm Nov 18, 2017
2f59b40
Allow failures on BETA
Nyholm Nov 18, 2017
092d832
typo
Nyholm Nov 18, 2017
37d3698
Test LTS releases
Nyholm Nov 18, 2017
7920c09
typos
Nyholm Nov 18, 2017
f066efb
Check if string contains slash
Nyholm Nov 18, 2017
14df844
Remove Symfony4.0 to see how travis behaves
Nyholm Nov 18, 2017
8a5122a
Make the PR ready for merge
Nyholm Nov 19, 2017
566ad7f
typo
Nyholm Nov 19, 2017
24ed526
Updated according to feedback
Nyholm Nov 25, 2017
5d04ded
Use tilde
Nyholm Nov 25, 2017
2a71c9b
Make sure tests passes
Nyholm Nov 29, 2017
88594a1
typo
Nyholm Nov 29, 2017
901d830
Do not run coverege on min-deps
Nyholm Nov 29, 2017
73d4ede
Introduce stability variable
Nyholm Nov 29, 2017
921ddba
typo
Nyholm Nov 29, 2017
518f86b
Fixes
Nyholm Nov 30, 2017
e9e9073
Added back PHPSpec 2
Nyholm Nov 30, 2017
8d1403b
fixed PHP versions
Nyholm Nov 30, 2017
bceddc0
Merge branch 'master' into Nyholm-patch-1
Nyholm Nov 30, 2017
8c62d22
Fixed deps low
Nyholm Nov 30, 2017
dcb2bca
Fixed typo
Nyholm Nov 30, 2017
9d5c846
Minor
Nyholm Nov 30, 2017
dc97863
Test on rc
Nyholm Nov 30, 2017
03ca9ce
PHP 7.1
Nyholm Nov 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 30 additions & 10 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,6 @@ cache:
directories:
- $HOME/.composer/cache/files

php:
- 5.4
- 5.5
- 5.6
- 7.0
- 7.1
- hhvm

env:
global:
- TEST_COMMAND="composer test"
Expand All @@ -27,18 +19,46 @@ branches:
matrix:
fast_finish: true
include:
- php: 7.1
env: COMPOSER_FLAGS="--prefer-stable --prefer-lowest" DEPENDENCIES="doctrine/instanciator:^1.0.5"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also instantiator. Apart from that, any reason why you're locking the version of it? If anything breaks with --prefer-lowest because an older version is installed, it needs to be fixed in that package and should probably be added here as a comment so the workaround can be removed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is adding the dependency for this one case, so its changing composer.json and thus needs a version constraint.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that, the question is: why do you need it as an explicit dependency?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Slack:

@fbourigault [11:18 AM]
$ composer why doctrine/instantiator
phpspec/phpspec 2.4.0 requires doctrine/instantiator (^1.0.1)
phpspec/prophecy 1.4.0 requires doctrine/instantiator (^1.0.2) (edited)
But it’s for unmaintained versions of those packagesages

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thank you for explaining 👍


# Test the latest stable release
- php: 5.4
env: COMPOSER_FLAGS="--prefer-stable --prefer-lowest" COVERAGE=true TEST_COMMAND="composer test-ci"
- php: 5.5
- php: 5.6
- php: 7.0
- php: 7.1
- php: 7.2
env: COVERAGE=true TEST_COMMAND="composer test-ci" DEPENDENCIES="henrikbjorn/phpspec-code-coverage:^1.0"

# Test LTS versions
- php: 7.1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Food for thought: test the LTS releases against the lowest common version they and this package supports. I'd say that people on LTS releases are less likely to always run on the latest PHP version, so testing against a lower version might be more comparable to real-world usage.

env: DEPENDENCIES="dunglas/symfony-lock:^2"
- php: 7.1
env: DEPENDENCIES="dunglas/symfony-lock:^3"
- php: 7.1
env: DEPENDENCIES="dunglas/symfony-lock:^4"

# Latest dev release
- php: 7.1
env: STABILITY="dev"

allow_failures:
# Latest dev is allowed to fail.
- env: STABILITY="dev"

before_install:
- if [[ $COVERAGE != true ]]; then phpenv config-rm xdebug.ini || true; fi
- if ! [ -z "$STABILITY" ]; then composer config minimum-stability ${STABILITY}; fi;
- if ! [ -z "$DEPENDENCIES" ]; then composer require --no-update ${DEPENDENCIES}; fi;

install:
# To be removed when this issue will be resolved: https://github.com/composer/composer/issues/5355
- if [[ "$COMPOSER_FLAGS" == *"--prefer-lowest"* ]]; then travis_retry composer update --prefer-dist --no-interaction --prefer-stable --quiet; fi
- travis_retry composer update ${COMPOSER_FLAGS} --prefer-dist --no-interaction
- composer update ${COMPOSER_FLAGS} --prefer-dist --no-interaction

script:
- composer validate --strict --no-check-lock
- $TEST_COMMAND

after_success:
Expand Down
5 changes: 2 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,14 @@
}
],
"require": {
"php": ">=5.4",
"php": "^5.4 || ^7.0",
"php-http/httplug": "^1.1",
"php-http/message-factory": "^1.0",
"php-http/message": "^1.6",
"symfony/options-resolver": "^2.6 || ^3.0 || ^4.0"
},
"require-dev": {
"phpspec/phpspec": "^2.4",
"henrikbjorn/phpspec-code-coverage" : "^1.0",
"phpspec/phpspec": "^2.5 || ^3.4 || ^4.2",
"guzzlehttp/psr7": "^1.4"
},
"suggest": {
Expand Down
2 changes: 1 addition & 1 deletion src/Plugin/ContentTypePlugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ private function isJson($stream)

json_decode($stream->getContents());

return JSON_ERROR_NONE == json_last_error();
return JSON_ERROR_NONE === json_last_error();
}

/**
Expand Down