Skip to content

Support PHPUnit 9 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 1, 2020
Merged

Support PHPUnit 9 #50

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
58b0bda
Test with PHPUnit 9
Nyholm Sep 30, 2020
a6d40a6
Allow more versions
Nyholm Sep 30, 2020
8588cea
Remove things not needed
Nyholm Sep 30, 2020
b41856b
minor
Nyholm Sep 30, 2020
23503ad
Update composer.json
Nyholm Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,14 @@ cache:
- $HOME/.composer/cache/files

php:
- 7.3
- 7.4

env:
- SUITE="curl" PACKAGE="php-http/curl-client:dev-master zendframework/zend-diactoros"
- SUITE="Socket" PACKAGE="php-http/socket-client:dev-master php-http/client-common"
- SUITE="Guzzle6" PACKAGE="php-http/guzzle6-adapter:dev-master"
- SUITE="Guzzle" PACKAGE="guzzlehttp/guzzle:dev-master"
- SUITE="Guzzle" PACKAGE="guzzlehttp/guzzle:dev-master phpunit/phpunit:^8.5.8"
- SUITE="React" PACKAGE="php-http/react-adapter:dev-master"
- SUITE="Buzz" PACKAGE="php-http/buzz-adapter:dev-master"
- SUITE="CakePHP" PACKAGE="php-http/cakephp-adapter:dev-master"
Expand Down
8 changes: 4 additions & 4 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
}
],
"require": {
"php": "^7.1",
"phpunit/phpunit": "^7.0 || ^8.0",
"php-http/message": "^1.0",
"guzzlehttp/psr7": "^1.0",
"php": ">=7.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i prefer to express this as ^7.1 || ^8.0 - we don't know if there will be breaking changes in PHP 9

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the argument from Symfony, basically:

"Using ^7.1 || ^8.0 will stop people from test with PHP 9 and you (the maintainer) will be responsible for making sure that it works on PHP 9. Using >=7.1 allows other to try with PHP 9 and report/fix issues.

However, I dont really mind either way. I'll change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, i don't understand that reasoning. i prefer it when people do a pull request to allow php 9 and we have a controlled way of seeing what is going on. otherwise people will just start using it and not be aware that its maybe not supported, and just complain. i feel with the restriction, it is less on the maintainer to make sure it works on php 9 than it is when we already allow it...

thanks for the change.

"phpunit/phpunit": "^7.5.20 || ^8.5.8 || ^9.3.11",
"php-http/message": "^1.0 || ^2.0",
"guzzlehttp/psr7": "^1.7",
"th3n3rd/cartesian-product": "^0.3"
},
"suggest": {
Expand Down
67 changes: 0 additions & 67 deletions src/FeatureTestListener.php
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions src/ResultPrinter.php
View file
Open in desktop

This file was deleted.