Support PSR-18 #43
Support PSR-18 #43
Conversation
src/Client.php
Outdated
| @@ -24,7 +25,7 @@ | |||
| * | |||
| * @since 1.0 | |||
| */ | |||
| class Client implements HttpClient, HttpAsyncClient | |||
| class Client implements HttpClient, HttpAsyncClient, ClientInterface | |||
There was a problem hiding this comment.
Would it make sense to let Http\Client\HttpClient extend Psr\Http\Client\ClientInterface? Then, HTTPlug consumers would not have to update their type hints if they are currently using HttpClient instead of a concrete implementation (hopefully they do).
There was a problem hiding this comment.
It already does. :)
I just added it here to be more explicit.
There was a problem hiding this comment.
Oh.. I got this error.
Class Http\Client\Curl\Client cannot implement previously implemented interface Psr\Http\Client\ClientInterface in /home/travis/build/php-http/curl-client/src/Client.php on line 28
| "ext-curl": "*", | ||
| "php-http/httplug": "^1.0", | ||
| "php-http/httplug": "^2.0", |
There was a problem hiding this comment.
HTTTPlug extends psr/http-client.
|
If this require a new major version why not requiring the psr only? EDIT : In fact may be better in a 3.0 so we let time for people to upgrade to the psr |
|
yes, see https://3v4l.org/Drbl2 |
|
We should probably create a |
|
i created the 1.7 branch from current master, and added the branch alias to this PR. |
composer.json
Outdated
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Looks likes this line has to be removed.
|
\o/ |
This will require a new major version. We do not have to release 2.0 right after merging this PR but we should release 2.0 this year.
This is just a "technical" BC break. We could consider other changes as well.