Support PSR-17 #52
Merged
Support PSR-17 #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cool! i think this is mainly a refactoring for psr-17 (the message factories) rather than psr-18 (which would replace the httplug client interface). as there is no async psr yet, i think this is the correct approach. httplug client 2.0 extends the psr-18 client, so this now is a psr-18 client (plus a httplug client) there are some conflicts, can you rebase on master? |
Nyholm
reviewed
Dec 30, 2018
| MessageFactory $messageFactory = null, | ||
| StreamFactory $streamFactory = null, | ||
| ResponseFactoryInterface $responseFactory = null, | ||
| StreamFactoryInterface $streamFactory = null, |
There was a problem hiding this comment.
we can now use the psr17 factory for these. lets keep using that for ease of use?
# Conflicts: # tests/BaseUnitTestCase.php # tests/CurlPromiseTest.php # tests/Functional/HttpClientTestCase.php # tests/HttpAsyncClientTestCase.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41
Requires php-http/discovery#116