Skip to content

Updated checks for Symfony #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2019
Merged

Updated checks for Symfony #151

merged 1 commit into from
Dec 17, 2019

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Dec 16, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #150
Documentation
License MIT

Symfony's HTTP client and the PSR18 client define conditions before we can use the class.

This PR reflects those conditions in the common strategy.

dbu
dbu approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@dbu dbu merged commit 6a5cb62 into php-http:master Dec 17, 2019
@XWB
Copy link

XWB commented Dec 18, 2019

@Nyholm @dbu Would you be so kind to tag a new release?

@dbu
Copy link
Contributor

dbu commented Dec 18, 2019

i hope to get #148 in as well.

@Nyholm Nyholm deleted the sf branch December 26, 2019 15:04
@dbu dbu mentioned this pull request Dec 27, 2019
Closed
@dbu
Copy link
Contributor

dbu commented Dec 27, 2019

1.7.2 is now tagged

@XWB XWB mentioned this pull request Dec 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nyholm @XWB @dbu