Skip to content

Added more common errors #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 24, 2016
Merged

Added more common errors #165

merged 7 commits into from
Nov 24, 2016

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Nov 18, 2016

No description provided.

@Nyholm
Copy link
Member Author

Nyholm commented Nov 18, 2016

How can I tell the spell checker to ignore this error?
https://travis-ci.org/php-http/documentation/builds/176956207#L358

They complain about me writing

install a package providing 'php-http/client-implementation'

need to install those libraries. If you want to use Guzzle you may run:
The error "*No message factories found. To use Guzzle, Diactoros or Slim Framework factories install php-http/message
and the chosen message implementation.*"
tells you that no discovery strategy could not find an installed implementation of PSR-7 and/or factories for that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could find

^^^^^^^^^^^^^^^^^^^^^^^^

The error "No HTTPlug clients found. Make sure to install a package providing 'php-http/client-implementation'*" says that
we cant find a client. See our :doc:`list of clients <clients>` and install one of them.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't or cannot

@Nyholm
Copy link
Member Author

Nyholm commented Nov 18, 2016

Thank you. I've updated the PR.

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

If you get an error saying "*Could not find resource using any discovery strategy.*" it means that all the
discovery [#strategies]_ have failed. The cause of this is probably because you have not installed message factories
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cause and because don't work in the same sentence afaik.

Most likely, your project is missing the message factories and/or a PRS-7 implementation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe the "Too many autonumbered footnote references" error is because of [#strategies]_ - i am not sure what this would be but our other links use the format :ref:text ``

No HTTPlug clients found
^^^^^^^^^^^^^^^^^^^^^^^^

The error "No HTTPlug clients found. Make sure to install a package providing 'php-http/client-implementation'*" says that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be consistent, you need to start with "* as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've missed that. Thank you

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

If you get an error saying "*Could not find resource using any discovery strategy.*" it means that all the
discovery [#strategies]_ have failed. Most likely, your project is missing the message factories and/or a PRS-7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you check the [#strategies]_ bit? i still suspect this to be the cause for the build error

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does. How would I make a link up to the Strategies heading?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

define an anchor like this above the heading:

.. _message-factory:

and reference it with :ref:linktext ``. this works across the whole documentation, not just within a page. try to "namespace" the anchor a bit, just "strategies" would be a bit week. e.g. "discovery-strategies"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I havnt seen that before.

Done

@dbu
Copy link
Contributor

dbu commented Nov 18, 2016

looks good to me now.

one thing: i try to break lines after 80 characters for nicer diffs, but actually not sure what our general policy on this is?

@Nyholm
Copy link
Member Author

Nyholm commented Nov 18, 2016

Thank you. I will try to do that in the future.
I know Symfony has such policies.

@Nyholm
Copy link
Member Author

Nyholm commented Nov 24, 2016

Are we happy with this PR?

@dbu
Copy link
Contributor

dbu commented Nov 24, 2016

apart from the formatting question with long lines, yes ;-)

@dbu dbu merged commit 8abb042 into php-http:master Nov 24, 2016
@dbu
Copy link
Contributor

dbu commented Nov 24, 2016

thanks a lot!

@Nyholm Nyholm deleted the errors branch November 24, 2016 10:09
@Nyholm
Copy link
Member Author

Nyholm commented Nov 24, 2016

Thank you for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants