Skip to content

clarify bundle installation #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2017
Merged

clarify bundle installation #198

merged 1 commit into from
May 24, 2017

Conversation

dbu
Copy link
Contributor

@dbu dbu commented May 23, 2017

the composer command should not fail when this page is somebody's entry point on how to set up HTTPlug

$ composer require php-http/httplug-bundle
$ composer require php-http/httplug-bundle <your client adapter choice>

If you did not install HTTPlug itself, you will also need to specify which HTTP
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand this line. Are you trying to say something like:
"If composer fails to install the bundle, you have to specify which HTTP..."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. how about:

" If you have not already installed a HTTP client, you need to specify the client when installing the bundle. See [link] for a list of available clients"

@dbu
Copy link
Contributor Author

dbu commented May 23, 2017 via email

@fbourigault
Copy link
Contributor

fbourigault commented May 23, 2017

I would say:

$ composer require php-http/httplug-bundle <your client adapter choice>
You can find an available client adapter here(link to the right page). However you can omit the client adapter if you already have one installed.

EDIT: we should probably suggest a suitable client implementation such as guzzle6 as it does not require more dependencies (message, factory, etc...). I also suggested to tell user to require the adapter unless they have one as I think most user workflow, in a Symfony project, is to require the bundle which depends on the library.

@dbu dbu force-pushed the bundle-installation branch from dc6dfcb to d1d1145 Compare May 24, 2017 06:29
@dbu
Copy link
Contributor Author

dbu commented May 24, 2017 via email

@dbu dbu merged commit 11cd969 into master May 24, 2017
@dbu dbu deleted the bundle-installation branch May 24, 2017 08:14
@dbu dbu removed the in progress label May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants