Skip to content

Added info about the "service" key for the bundle #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2018
Merged

Added info about the "service" key for the bundle #230

merged 2 commits into from
Mar 27, 2018

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Mar 27, 2018

screen shot 2018-03-27 at 08 34 16

screen shot 2018-03-27 at 08 34 33

@Nyholm Nyholm requested a review from dbu March 27, 2018 06:36
@Nyholm Nyholm mentioned this pull request Mar 27, 2018
Merged
dbu
dbu approved these changes Mar 27, 2018
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could use ..versionadded:: to avoid confusion

@Nyholm
Copy link
Member Author

Nyholm commented Mar 27, 2018

Excellent idea

screen shot 2018-03-27 at 09 03 30

@Nyholm Nyholm merged commit 2d6cab3 into master Mar 27, 2018
@Nyholm Nyholm deleted the patch-service branch March 27, 2018 07:27
@dbu
Copy link
Contributor

dbu commented Mar 27, 2018

great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nyholm @dbu