Restructure docs #52
Closed
Restructure docs #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,8 +15,15 @@ these details can be separated from the actual requests. | |||
| $ composer require php-http/message | |||
| ``` | |||
|
|
|||
| ## Authentication | |||
There was a problem hiding this comment.
i would split the message documentation into one page per aspect: auth, stream, decorator, factory, cookie. those docs are not very closely related, and will grow over time.
There was a problem hiding this comment.
I agree: roughly equivalent to the php-http/message directory listing.
sagikazarmark
force-pushed
the
merge_tree
branch
from
1ed8257 to
d655f33
Compare
|
Closing this as there are other PRs providing similar restructuring and we are moving to Sphinx anyway. |
| @@ -9,20 +9,18 @@ In both cases, the `Http\Client\HttpClient` provides a `sendRequest` method to s | |||
| and returns a PSR-7 `ResponseInterface`or throws an exception that implements `Http\Client\Exception`. | |||
|
|
|||
| There is also the `Http\Client\HttpAsyncClient` which provides the `sendAsyncRequest` method to send | |||
| a request asynchronously and returns a `Http\Client\Promise`. | |||
| a request asynchronously and returns a `Http\Promise\Promise`. | |||
There was a problem hiding this comment.
did this fix make it to master?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.