Spice up intro #60
Merged
Spice up intro #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WTF is happening with the diff? |
|
Yeah, this one failing just like #58. Let’s wait for GH support’s answer. |
|
looked at the diff on the cli and i like the changes a lot. imo we can merge this. one thing i wonder is whether we should not mention the message factories more prominently. besides the Httplug interface, they are key to build a client application that is not dependent on concrete implementations. whithout a factory, you would still have hard coupling to the message classes. |
|
👍 |
|
@dbu Agreed on the message factories: we should describe them in one or two sentences in the intro. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.