Skip to content

Changed the width of the toolbar image #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2016
Merged

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Mar 2, 2016

It was too small before.

@@ -67,7 +67,7 @@ If you want the bundle to automatically find usable factory classes, install and
classes:
client: Http\Adapter\Guzzle6\Client
message_factory: Http\Message\MessageFactory\GuzzleMessageFactory
uri_factory: Http\Message\UriFactory\GuzzleUriFactory
uri_factory: Http\Message\UriFactory\GuzzleUriFactorye
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo...

@Nyholm
Copy link
Member Author

Nyholm commented Mar 2, 2016

This PR does also include a fix for the services table. I removed the extra indentation

dbu added a commit that referenced this pull request Mar 2, 2016
Changed the width of the toolbar image
@dbu dbu merged commit 1b6ff9e into php-http:master Mar 2, 2016
@dbu
Copy link
Contributor

dbu commented Mar 2, 2016

thanks. ideally we could see a preview somewhere for such things...

@sagikazarmark
Copy link
Member

We can enable dev builds for each feature branch separately. But ideally you should build the docs locally to see things like this IMO

@Nyholm
Copy link
Member Author

Nyholm commented Mar 2, 2016

We can enable dev builds for each feature branch. But ideally you should build the docs locally to see things like this IMO

That would be awesome.

I have not been able to build the docs locally. Things does not go well with the sphinx-build on my computer. I get weird Python errors..

@Nyholm Nyholm deleted the patch-3 branch March 2, 2016 10:19
@sagikazarmark
Copy link
Member

That would be awesome.

But that must be done manually. 😉

I can add you to the docs if you wish, I will stick with local building. (At least on my linux machine, Python-OS X combo sucks for me as well)

@dbu
Copy link
Contributor

dbu commented Mar 2, 2016 via email

@Nyholm
Copy link
Member Author

Nyholm commented Mar 2, 2016

But that must be done manually. 😉
Ah okey..

Sure add me if it could help me preview my changes.

@Nyholm
Copy link
Member Author

Nyholm commented Mar 2, 2016

Thank you David. I'll try that

@sagikazarmark
Copy link
Member

That looks awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants