This repository was archived by the owner on Jan 6, 2024. It is now read-only.
Update guzzle6 adapater with httplug new contract #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "guzzlehttp/guzzle": "^6.0" | ||
| }, | ||
| "require-dev": { | ||
| "ext-curl": "*", | ||
| "php-http/adapter-integration-tests": "^0.1" | ||
| "php-http/message-factory": "dev-master as 0.1.1", |
There was a problem hiding this comment.
Why is this necessary? WHere is it used?
There was a problem hiding this comment.
Was used by the test which need discovery service, which need message factory
| try { | ||
| return $this->client->send($request, $options); | ||
| return $this->client->send($request, $this->options); |
There was a problem hiding this comment.
These options can also be configure in Guzzle at construction time, can't they? If so, we should just wrap the client and forget about options.
There was a problem hiding this comment.
Yes it's the same at the one in the construct of Guzzle, let's remove them.
sagikazarmark
added a commit
that referenced
this pull request
Oct 23, 2015
Update guzzle6 adapater with httplug new contract
|
Thanks @joelwurtz |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I update the guzzle6 adapter to work with the new contract of Httplug, all tests are green.
For the sendRequests method after viewing the guzzle implementation and discussing it with @sagikazarmark on Slack, we concluded there was no real benefits to wrap the Guzzle object as it does not store requests, responses or exceptions objects.